Pop-Up Thingie

The Horizon BBS
  • Home
  • Forum
  • Files
  • Register
  • Log in

  1. Forum
  2. DOVE-Net
  3. Synchronet Sysops
  • Merge branch 'dd_msg_reader_permission_check_optimizations' into 'mast

    From Rob Swindell@VERT to GitLab note in main/sbbs on Tue Oct 10 23:08:19 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4319

    You don't need to open a message base to check its configuration. This will definitely slow down this function unnecessarily.

    Instead:
    ```
    canDelete = Boolean(msg_area.sub[this.subBoardCode].settings & SUB_DEL);
    ```

    I'm not clear why you're doing the ```canDelete = canDelete ||` either. Since you've already checked that `CanDelete` is false, that seems unnecessary. And the `== SUB_DEL` is also unnecessary.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Tue Oct 10 23:09:33 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4320

    Ditto here. Not necessary to open the message base.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Tue Oct 10 23:10:32 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4321

    Here too. And you've got the other unnecessary bits too.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Tue Oct 10 23:10:51 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4322

    Same here. :-)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Eric Oulashin@VERT to GitLab note in main/sbbs on Wed Oct 11 09:01:26 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4323

    Thanks. Also, I realized afterward I don't need the "canDelete ||".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • Who's Online

  • Recent Visitors

    • Dave Drum
      Thu Jun 12 19:26:59 2025
      from Springfield, Illinois via Telnet
    • Dave Drum
      Thu Jun 12 19:11:17 2025
      from Springfield, Illinois via Telnet
    • Dave Drum
      Thu Jun 12 18:55:19 2025
      from Springfield, Illinois via Telnet
    • Genalb
      Thu Jun 12 07:15:59 2025
      from Slc, Utah via Telnet
  • System Info

    Sysop: Chris Crash
    Location: Huntington Beach, CA.
    Users: 615
    Nodes: 8 (0 / 8)
    Uptime: 31:18:18
    Calls: 10,874
    Files: 5
    Messages: 517,503

© The Horizon BBS, 2025